forked from smol-ai/GodMode
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle for dark and light mode — updates to #96 #1
Open
seanoliver
wants to merge
30
commits into
eshack94:add-toggle-for-dark-and-light-mode
Choose a base branch
from
smol-ai:add-toggle-for-dark-and-light-mode
base: add-toggle-for-dark-and-light-mode
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add toggle for dark and light mode — updates to #96 #1
seanoliver
wants to merge
30
commits into
eshack94:add-toggle-for-dark-and-light-mode
from
smol-ai:add-toggle-for-dark-and-light-mode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seanoliver <[email protected]>
Co-authored-by: swyxio <[email protected]>
…dify window hiding function with manual flag, feat(index.js) add double-click on tray for quicker open.
Co-authored-by: swyxio <[email protected]>
…e unnecessary exports
…ctron ipcRenderer, refactor(provider) remove unnecessary white spaces
incredible! trying this out now |
merged in smol-ai#107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eshack94 @swyxio — It's alive! Merging this change into @eshack94's branch, and I think (assuming we are okay with the fact that this doesn't yet work for Bing) we should be good to merge this in with main.
@eshack94 I hope you don't mind me jumping in on this; I started by making a few small changes and then got carried away.
FYI that I had to bring it back up to speed with main in order to access the "dev mode" change we recently made makes debugging the individual webviews a lot easier, so unfortunately it looks like more files have been touched than necessarily have. Basically, this includes all of the recent changes we made around removing full screen mode, adding dev mode, adding Together as a provider, and a few updates to the README.
So if you ignore edits related to those things here's what changed:
handleDarkMode()
method into the parent Provider class with a default implementation that works out of the box for most providers (i.e. just adding and removing the 'dark' class from thehtml
tag).interface.js
.Unfortunately, something is still not working with dark mode for Phind and Bing. I can get them working to work in the chrome console so there must be something else going on here.
But besides those two, it's looking good!
darkmode-top4.mp4
If you're both in agreement, we can merge this into @eshack94's branch and then merge @eshack94's branch into main.